Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French verb negation #44

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

ollylucl
Copy link
Contributor

@ollylucl ollylucl commented Jun 5, 2024

Description

Added negator that changes a French sentence from positive to negative.

Note that it does not convert negative to positive.

Fixes # (issue)

Adds functionality suggested in https://github.com/harmonydata/hackathon/blob/main/5-multilingual.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Requires a documentation revision

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • cd tests; python test_negator.py
  • Test B

Test Configuration

  • Library version:
  • OS:
  • Toolchain:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Note that it does not convert negative to positive.
@woodthom2 woodthom2 merged commit f8b4482 into harmonydata:main Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants